Automatically grant permissions to default-installed extensions

Automatically grant permissions to default-installed extensions

This is a small change to the logic underlying auto
permission grants for default-installed extensions.

This causes permissions to actually be granted as
intended, rather than simply bypassing the prompt.

BUG=450300
R=kalman@chromium.org

Committed: https://crrev.com/1d4a06266c0abc6be779f8acf50cb2f18c5c0d89
Cr-Commit-Position: refs/heads/master@{#316628}

[Ken Rockot(use gerrit already), 2015-02-17 18:22:21]

This effectively reverts the last CL and modifies ExtensionService behavior
instead.

[not at google - send to devlin, 2015-02-17 18:30:36]

Fun (lgtm).

CanSilentlyIncreasePermissions does seem like a pretty useless helper to me. IMO
it should be moved back into ES, but not particularly important to do so.

https://codereview.chromium.org/934753005/diff/1/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/934753005/diff/1/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_service.cc:1590: // in kiosk mode.
nit: move this comment above the assignment to auto_grant_permission

[Ken Rockot(use gerrit already), 2015-02-17 18:31:36]

New patchsets have been uploaded after l-g-t-m from kalman@chromium.org

[Ken Rockot(use gerrit already), 2015-02-17 18:32:28]

Agreed, done and done.

[Ken Rockot(use gerrit already), 2015-02-17 18:33:59]

The CQ bit was checked by rockot@chromium.org

[not at google - send to devlin, 2015-02-17 18:34:41]

https://codereview.chromium.org/934753005/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/934753005/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_service.cc:1597: // installed internally.
Second half of this comment is reversed, right?

[commit-bot: I haz the power, 2015-02-17 18:34:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/934753005/40001

[Ken Rockot(use gerrit already), 2015-02-17 18:35:24]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2015-02-17 18:36:06]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2015-02-17 18:36:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/934753005/60001

[commit-bot: I haz the power, 2015-02-17 19:39:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-17 19:40:26]

Patchset 4 (id:??) landed as
https://crrev.com/1d4a06266c0abc6be779f8acf50cb2f18c5c0d89
Cr-Commit-Position: refs/heads/master@{#316628}