Add DCHECK that HistoryURLProvider is on the main thread

Add DCHECK that HistoryURLProvider is on the main thread.

It needs to be there to use the field trial stuff.


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121459

[Mark P, 2012-02-09 16:21:30]

DCHECKs are handy things.

--mark

[Peter Kasting, 2012-02-09 21:51:19]

LGTM

http://codereview.chromium.org/9347030/diff/12005/chrome/browser/autocomplete...
File chrome/browser/autocomplete/history_url_provider.cc (right):

http://codereview.chromium.org/9347030/diff/12005/chrome/browser/autocomplete...
chrome/browser/autocomplete/history_url_provider.cc:351: // For the field trial
stuff to work correctly, we must be running
I wonder if the field trial is the only requirement imposition here.  It seems
like to use the in-memory data structures we also need to be on the main thread?
 Maybe this check should move to the top of the constructor?  Might be good to
ask Mike.

http://codereview.chromium.org/9347030/diff/12005/chrome/browser/autocomplete...
chrome/browser/autocomplete/history_url_provider.cc:358: // CurrentlyOn(UI
thread will fail.)
Nit: Missing paren after "thread"

[mrossetti, 2012-02-09 21:58:58]

http://codereview.chromium.org/9347030/diff/12005/chrome/browser/autocomplete...
File chrome/browser/autocomplete/history_url_provider.cc (right):

http://codereview.chromium.org/9347030/diff/12005/chrome/browser/autocomplete...
chrome/browser/autocomplete/history_url_provider.cc:351: // For the field trial
stuff to work correctly, we must be running
I was considering suggesting that the DCHECK be placed in the
AutocompleteProvider ctor.

On 2012/02/09 21:51:19, Peter Kasting wrote:
> I wonder if the field trial is the only requirement imposition here.  It seems
> like to use the in-memory data structures we also need to be on the main
thread?
>  Maybe this check should move to the top of the constructor?  Might be good to
> ask Mike.

[Mark P, 2012-02-09 22:17:46]

If there are no objections, I'll check this in soon (probably tomorrow morning
my time).

--mark

http://codereview.chromium.org/9347030/diff/12005/chrome/browser/autocomplete...
File chrome/browser/autocomplete/history_url_provider.cc (right):

http://codereview.chromium.org/9347030/diff/12005/chrome/browser/autocomplete...
chrome/browser/autocomplete/history_url_provider.cc:351: // For the field trial
stuff to work correctly, we must be running

I think we should pepper our code with these DCHECKs where we think it's
appropriate.  I think this place is a good stop for this one because we have a
good reason to put one here.  I'm not opposed to adding others (in other
changelists).

On 2012/02/09 21:58:58, mrossetti wrote:
> I was considering suggesting that the DCHECK be placed in the
> AutocompleteProvider ctor.
> 
> On 2012/02/09 21:51:19, Peter Kasting wrote:
> > I wonder if the field trial is the only requirement imposition here.  It
seems
> > like to use the in-memory data structures we also need to be on the main
> thread?
> >  Maybe this check should move to the top of the constructor?  Might be good
to
> > ask Mike.
>

http://codereview.chromium.org/9347030/diff/12005/chrome/browser/autocomplete...
chrome/browser/autocomplete/history_url_provider.cc:358: // CurrentlyOn(UI
thread will fail.)
On 2012/02/09 21:51:19, Peter Kasting wrote:
> Nit: Missing paren after "thread"

Fixed.

[commit-bot: I haz the power, 2012-02-10 13:12:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/9347030/15002

[commit-bot: I haz the power, 2012-02-10 16:34:24]

Change committed as 121459