Reload favicon from HTTP cache on Ctrl+Refresh

content/common/image_messages.h

Index: content/common/image_messages.h
diff --git a/content/common/image_messages.h b/content/common/image_messages.h
index b8869087fdeda1d80fa4968baa230d178146524b..fe2f21f6bc19a5b2e9c33c66befc4aee2e891b6d 100644
--- a/content/common/image_messages.h
+++ b/content/common/image_messages.h
@@ -8,16 +8,18 @@
 #include "ipc/ipc_message.h"
 #include "ipc/ipc_message_macros.h"
 #include "ipc/ipc_param_traits.h"
+#include "third_party/WebKit/public/platform/WebURLRequest.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/geometry/size.h"
 
 #define IPC_MESSAGE_START ImageMsgStart
 
 // Messages sent from the browser to the renderer.
+IPC_ENUM_TRAITS(blink::WebURLRequest::CachePolicy);

[pkotwicz, 2015/02/19 16:47:02]

This is a style violation + DEPS violation.
- I did not want to pass a boolean variable via the IPC
- content/common suggests that I would need to pull the enum into its own file
in order to use it here. Before doing all of that work, I wanted to get sign off
on using this enum (v.s. using a boolean or a different enum)

 
 // Requests the renderer to download the specified image, decode it,
 // and send the image data back via ImageHostMsg_DidDownloadImage.
-IPC_MESSAGE_ROUTED4(ImageMsg_DownloadImage,
+IPC_MESSAGE_ROUTED5(ImageMsg_DownloadImage,
                     int /* Identifier for the request */,
                     GURL /* URL of the image */,
                     bool /* is favicon (turn off cookies) */,
@@ -26,7 +28,8 @@ IPC_MESSAGE_ROUTED4(ImageMsg_DownloadImage,
                                 bitmaps at the passed in GURL <= max size, the
                                 smallest bitmap is resized to the max size and
                                 is the only result. A max size of zero means
-                                that the max size is unlimited. */)
+                                that the max size is unlimited. */,
+                    blink::WebURLRequest::CachePolicy /* cache policy */)
 
 // Messages sent from the renderer to the browser.