Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2440)

Unified Diff: extensions/browser/app_window/app_window.cc

Issue 934693002: Reload favicon from HTTP cache on Ctrl+Refresh (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/image_loading_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/app_window/app_window.cc
diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc
index 7d0e7c34ef7ea0eafa0c48d6300dfb2c6e917727..0689b136685651ce0300c4aef4bb2438961ce7ac 100644
--- a/extensions/browser/app_window/app_window.cc
+++ b/extensions/browser/app_window/app_window.cc
@@ -525,8 +525,9 @@ void AppWindow::SetAppIconUrl(const GURL& url) {
app_icon_url_ = url;
web_contents()->DownloadImage(
url,
- true, // is a favicon
- 0, // no maximum size
+ true, // is a favicon
+ 0, // no maximum size
+ false, // normal cache policy
base::Bind(&AppWindow::DidDownloadFavicon,
image_loader_ptr_factory_.GetWeakPtr()));
}
@@ -541,8 +542,9 @@ void AppWindow::SetBadgeIconUrl(const GURL& url) {
badge_icon_url_ = url;
web_contents()->DownloadImage(
url,
- true, // is a favicon
- 0, // no maximum size
+ true, // is a favicon
+ 0, // no maximum size
+ false, // normal cache policy
base::Bind(&AppWindow::DidDownloadFavicon,
image_loader_ptr_factory_.GetWeakPtr()));
}
« no previous file with comments | « content/renderer/image_loading_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698