Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 934693002: Reload favicon from HTTP cache on Ctrl+Refresh (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/image_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 97813f709b6f6b068fad1a98409333dac8df6fbb..1f753882b94bfc71f3a3454e352ff30f9385f281 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -134,13 +134,15 @@ g_created_callbacks = LAZY_INSTANCE_INITIALIZER;
static int StartDownload(RenderFrameHost* rfh,
const GURL& url,
bool is_favicon,
- uint32_t max_bitmap_size) {
+ uint32_t max_bitmap_size,
+ bool bypass_cache) {
static int g_next_image_download_id = 0;
rfh->Send(new ImageMsg_DownloadImage(rfh->GetRoutingID(),
++g_next_image_download_id,
url,
is_favicon,
- max_bitmap_size));
+ max_bitmap_size,
+ bypass_cache));
return g_next_image_download_id;
}
@@ -2566,8 +2568,10 @@ void WebContentsImpl::DidEndColorChooser() {
int WebContentsImpl::DownloadImage(const GURL& url,
bool is_favicon,
uint32_t max_bitmap_size,
+ bool bypass_cache,
const ImageDownloadCallback& callback) {
- int id = StartDownload(GetMainFrame(), url, is_favicon, max_bitmap_size);
+ int id = StartDownload(GetMainFrame(), url, is_favicon, max_bitmap_size,
+ bypass_cache);
image_download_map_[id] = callback;
return id;
}
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/image_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698