Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2011)

Unified Diff: chrome/browser/favicon/favicon_handler.h

Issue 934693002: Reload favicon from HTTP cache on Ctrl+Refresh (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_handler.h
diff --git a/chrome/browser/favicon/favicon_handler.h b/chrome/browser/favicon/favicon_handler.h
index 55656a660b1f780fe776e7f1a7cd4d3e77f88618..e4f82ad140b78fbfee81254723e370db0e3609e6 100644
--- a/chrome/browser/favicon/favicon_handler.h
+++ b/chrome/browser/favicon/favicon_handler.h
@@ -149,7 +149,9 @@ class FaviconHandler {
virtual bool ShouldSaveFavicon(const GURL& url);
private:
- friend class TestFaviconHandler; // For testing
+ // For testing:
+ friend class FaviconTabHelperTest;
+ friend class TestFaviconHandler;
// Represents an in progress download of an image from the renderer.
struct DownloadRequest {
@@ -258,7 +260,10 @@ class FaviconHandler {
// URL of the page we're requesting the favicon for.
GURL url_;
- // Whether we got the initial response for the favicon back from the renderer.
+ // Whether we are waiting for data from the FaviconService.
+ bool waiting_for_favicon_service_data_;
+
+ // Whether we got data back for the initial request to the FaviconService.
bool got_favicon_from_history_;
// Whether the favicon is out of date or the favicon data in

Powered by Google App Engine
This is Rietveld 408576698