Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 934683004: Fix closure compiler errors which are introduced by 931603002. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix closure compiler errors which are introduced by 931603002. BUG=456016 TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/foreground/js/compiled_resources.gyp && ninja -C out/Default Committed: https://crrev.com/86aeb178ba7f614bc40621323704450389c0a31a Cr-Commit-Position: refs/heads/master@{#316540}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_contents.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
My CL (http://crrev.com/931603002) has broken the closure compiler bot. PTAL. Thank you!
5 years, 10 months ago (2015-02-17 07:09:44 UTC) #2
hirono
lgtm!
5 years, 10 months ago (2015-02-17 07:10:49 UTC) #3
yawano
On 2015/02/17 07:10:49, hirono wrote: > lgtm! Thank you!
5 years, 10 months ago (2015-02-17 07:16:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934683004/1
5 years, 10 months ago (2015-02-17 07:17:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 07:29:54 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 07:30:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86aeb178ba7f614bc40621323704450389c0a31a
Cr-Commit-Position: refs/heads/master@{#316540}

Powered by Google App Engine
This is Rietveld 408576698