Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 934673002: Remove transparency from inactive ash app windows. (Closed)

Created:
5 years, 10 months ago by benwells
Modified:
5 years, 10 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, kalyank, sadrul, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove transparency from inactive ash app windows. BUG=458232 Committed: https://crrev.com/46e291af7e01c99395c1e52275ce901540ec527f Cr-Commit-Position: refs/heads/master@{#316635}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M ash/frame/default_header_painter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/frame/default_header_painter.cc View 3 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
benwells
5 years, 10 months ago (2015-02-17 03:21:00 UTC) #2
pkotwicz
LGTM I never liked the partially transparent headers anyway
5 years, 10 months ago (2015-02-17 18:14:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934673002/1
5 years, 10 months ago (2015-02-17 19:53:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 19:57:22 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 19:58:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46e291af7e01c99395c1e52275ce901540ec527f
Cr-Commit-Position: refs/heads/master@{#316635}

Powered by Google App Engine
This is Rietveld 408576698