Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 934623003: Revert of MIPS: Fix 'Assembler support for internal references.' (Closed)

Created:
5 years, 10 months ago by Michael Achenbach
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of MIPS: Fix 'Assembler support for internal references.' (patchset #1 id:1 of https://codereview.chromium.org/922043005/) Reason for revert: Breaks http://build.chromium.org/p/chromium.fyi/builders/Android%20MIPS%20Builder%20(dbg) Original issue's description: > MIPS: Fix 'Assembler support for internal references.' > > Added new INTERNAL_REFERENCE_ENCODED RelocInfo type to differentiate MIPS existing use of internal references in instructions from the new raw pointer reference needed for dd(Label*). > > BUG= > TEST=cctest/test-assembler-mips/jump_tables1, cctest/test-assembler-mips/jump_tables2, cctest/test-assembler-mips/jump_tables3, cctest/test-run-machops/RunSwitch1 > > Committed: https://crrev.com/244ac6de8316259bc5878480e05348a369c08e2f > Cr-Commit-Position: refs/heads/master@{#26651} TBR=danno@chromium.org,bmeurer@chromium.org,jkummerow@chromium.org,paul.lind@imgtec.com,gergely.kis@imgtec.com,akos.palfi@imgtec.com,dusan.milosavljevic@imgtec.com,balazs.kilvady@imgtec.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/4fdac75d9f666ad15329dea3570b17911514eb41 Cr-Commit-Position: refs/heads/master@{#26675}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -123 lines) Patch
M src/assembler.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/mips/assembler-mips.h View 5 chunks +4 lines, -11 lines 0 comments Download
M src/mips/assembler-mips.cc View 12 chunks +87 lines, -99 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/constants-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of MIPS: Fix 'Assembler support for internal references.'
5 years, 10 months ago (2015-02-16 18:48:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934623003/1
5 years, 10 months ago (2015-02-16 18:49:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-16 18:49:43 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 18:49:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fdac75d9f666ad15329dea3570b17911514eb41
Cr-Commit-Position: refs/heads/master@{#26675}

Powered by Google App Engine
This is Rietveld 408576698