Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 934603002: [memory-inspector] Replace getprop line splitting with a regex (Closed)

Created:
5 years, 10 months ago by petrcermak
Modified:
5 years, 10 months ago
CC:
chromium-reviews, picksi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[memory-inspector] Replace getprop line splitting with a regex BUG=459010 Committed: https://crrev.com/3487f329fc13a6a90741c216f2534c9f4aa48c08 Cr-Commit-Position: refs/heads/master@{#316551}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update for review feedback #

Patch Set 3 : Increment version number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M tools/memory_inspector/chrome_app/template/manifest.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/memory_inspector/memory_inspector/backends/adb_client.py View 1 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
petrcermak
5 years, 10 months ago (2015-02-16 15:52:40 UTC) #2
picksi
https://codereview.chromium.org/934603002/diff/1/tools/memory_inspector/memory_inspector/backends/adb_client.py File tools/memory_inspector/memory_inspector/backends/adb_client.py (right): https://codereview.chromium.org/934603002/diff/1/tools/memory_inspector/memory_inspector/backends/adb_client.py#newcode25 tools/memory_inspector/memory_inspector/backends/adb_client.py:25: GETPROP_PATTERN = re.compile(r'^\[([^\]]*)\]: \[(.*?)\]$', It might be worth adding ...
5 years, 10 months ago (2015-02-16 16:01:23 UTC) #4
petrcermak
https://codereview.chromium.org/934603002/diff/1/tools/memory_inspector/memory_inspector/backends/adb_client.py File tools/memory_inspector/memory_inspector/backends/adb_client.py (right): https://codereview.chromium.org/934603002/diff/1/tools/memory_inspector/memory_inspector/backends/adb_client.py#newcode25 tools/memory_inspector/memory_inspector/backends/adb_client.py:25: GETPROP_PATTERN = re.compile(r'^\[([^\]]*)\]: \[(.*?)\]$', On 2015/02/16 16:01:23, picksi wrote: ...
5 years, 10 months ago (2015-02-16 16:13:05 UTC) #5
Primiano Tucci (use gerrit)
LGTM thanks. (I took the liberty of retouching a bit the CL title before ticking ...
5 years, 10 months ago (2015-02-17 09:41:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934603002/40001
5 years, 10 months ago (2015-02-17 09:41:40 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-17 10:02:02 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 10:02:44 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3487f329fc13a6a90741c216f2534c9f4aa48c08
Cr-Commit-Position: refs/heads/master@{#316551}

Powered by Google App Engine
This is Rietveld 408576698