Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Unified Diff: src/objects.h

Issue 934463003: super.property store (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: git rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 5aceb1023629d09bd0458a2a254da531f6f031c6..d4af4a6255c1d1d1765f8d66ea2e7c0e1436978e 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -1017,8 +1017,6 @@ class Object {
CERTAINLY_NOT_STORE_FROM_KEYED
};
- enum StorePropertyMode { NORMAL_PROPERTY, SUPER_PROPERTY };
-
INLINE(bool IsFixedArrayBase() const);
INLINE(bool IsExternal() const);
INLINE(bool IsAccessorInfo() const);
@@ -1128,13 +1126,23 @@ class Object {
MUST_USE_RESULT static MaybeHandle<Object> SetProperty(
LookupIterator* it, Handle<Object> value, LanguageMode language_mode,
- StoreFromKeyed store_mode,
- StorePropertyMode data_store_mode = NORMAL_PROPERTY);
+ StoreFromKeyed store_mode);
+
+ MUST_USE_RESULT static MaybeHandle<Object> SetSuperProperty(
+ LookupIterator* it, Handle<Object> value, LanguageMode language_mode,
+ StoreFromKeyed store_mode);
+
MUST_USE_RESULT static MaybeHandle<Object> WriteToReadOnlyProperty(
LookupIterator* it, Handle<Object> value, LanguageMode language_mode);
+ MUST_USE_RESULT static MaybeHandle<Object> WriteToReadOnlyProperty(
+ Isolate* isolate, Handle<Object> reciever, Handle<Object> name,
+ Handle<Object> value, LanguageMode language_mode);
MUST_USE_RESULT static MaybeHandle<Object> WriteToReadOnlyElement(
Isolate* isolate, Handle<Object> receiver, uint32_t index,
Handle<Object> value, LanguageMode language_mode);
+ MUST_USE_RESULT static MaybeHandle<Object> RedefineNonconfigurableProperty(
+ Isolate* isolate, Handle<Object> name, Handle<Object> value,
+ LanguageMode language_mode);
MUST_USE_RESULT static MaybeHandle<Object> SetDataProperty(
LookupIterator* it, Handle<Object> value);
MUST_USE_RESULT static MaybeHandle<Object> AddDataProperty(
@@ -1254,6 +1262,11 @@ class Object {
// Return the map of the root of object's prototype chain.
Map* GetRootMap(Isolate* isolate);
+ // Helper for SetProperty and SetSuperProperty.
+ MUST_USE_RESULT static MaybeHandle<Object> SetPropertyInternal(
+ LookupIterator* it, Handle<Object> value, LanguageMode language_mode,
+ StoreFromKeyed store_mode, bool* found);
+
DISALLOW_IMPLICIT_CONSTRUCTORS(Object);
};
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698