Fix for white screen when casting on Android.

Fix for white screen when casting on Android.

This was fixed a while back on Chromecast, but no equivalent fix
was made for Android.

BUG=internal b/19484287

Committed: https://crrev.com/f428c79fe88b2458ea659c889227a40383e65e23
Cr-Commit-Position: refs/heads/master@{#317759}

[halliwell, 2015-02-24 00:52:57]

halliwell@chromium.org changed reviewers:
+ gunsch@chromium.org

[gunsch, 2015-02-24 01:16:01]

On 2015/02/24 00:53:04, halliwell wrote:

Thanks for the fix! Looks okay, but I think you need to sync---CastWindowAndroid
was largely rewritten recently-ish.

[halliwell, 2015-02-24 05:32:12]

On 2015/02/24 01:16:01, gunsch wrote:
> On 2015/02/24 00:53:04, halliwell wrote:
> 
> Thanks for the fix! Looks okay, but I think you need to
sync---CastWindowAndroid
> was largely rewritten recently-ish.

Doh.  Updated & merged ... PTAL :)

[gunsch, 2015-02-24 05:55:09]

lgtm % comment

https://codereview.chromium.org/934433003/diff/20001/chromecast/browser/andro...
File chromecast/browser/android/cast_window_android.cc (right):

https://codereview.chromium.org/934433003/diff/20001/chromecast/browser/andro...
chromecast/browser/android/cast_window_android.cc:47:
window_android->web_contents_->GetRenderWidgetHostView();
optional: instead of accessing web_contents_ (private member from a static
method), you could call web_contents() API (provided by WebContentsDelegate*).

[halliwell, 2015-02-24 06:23:43]

https://codereview.chromium.org/934433003/diff/20001/chromecast/browser/andro...
File chromecast/browser/android/cast_window_android.cc (right):

https://codereview.chromium.org/934433003/diff/20001/chromecast/browser/andro...
chromecast/browser/android/cast_window_android.cc:47:
window_android->web_contents_->GetRenderWidgetHostView();
On 2015/02/24 05:55:09, gunsch wrote:
> optional: instead of accessing web_contents_ (private member from a static
> method), you could call web_contents() API (provided by WebContentsDelegate*).

I don't believe there is such an API?  WebContentsDelegate actually maintains an
entire set of WebContents*'s.

Is private member from a static method a problem in the style guide?  If so, we
could add an accessor into CastWindowAndroid.  If not ... I don't personally
have a problem with it, at least not for simple cases like this.

[gunsch, 2015-02-24 06:27:09]

On 2015/02/24 06:23:43, halliwell wrote:
>
https://codereview.chromium.org/934433003/diff/20001/chromecast/browser/andro...
> File chromecast/browser/android/cast_window_android.cc (right):
> 
>
https://codereview.chromium.org/934433003/diff/20001/chromecast/browser/andro...
> chromecast/browser/android/cast_window_android.cc:47:
> window_android->web_contents_->GetRenderWidgetHostView();
> On 2015/02/24 05:55:09, gunsch wrote:
> > optional: instead of accessing web_contents_ (private member from a static
> > method), you could call web_contents() API (provided by
WebContentsDelegate*).
> 
> I don't believe there is such an API?  WebContentsDelegate actually maintains
an
> entire set of WebContents*'s.
> 
> Is private member from a static method a problem in the style guide?  If so,
we
> could add an accessor into CastWindowAndroid.  If not ... I don't personally
> have a problem with it, at least not for simple cases like this.

Ha, sent you down the wrong path because I said WebContentsDelegate when I meant
WebContentsObserver :(

https://code.google.com/p/chromium/codesearch#chromium/src/content/public/bro...

but alternately it's really fine as-is, hence "optional", just a stylistic
preference and thought I'd point out the API was there. Feel free to submit.

[halliwell, 2015-02-24 06:32:06]

On 2015/02/24 06:27:09, gunsch wrote:
> On 2015/02/24 06:23:43, halliwell wrote:
> >
>
https://codereview.chromium.org/934433003/diff/20001/chromecast/browser/andro...
> > File chromecast/browser/android/cast_window_android.cc (right):
> > 
> >
>
https://codereview.chromium.org/934433003/diff/20001/chromecast/browser/andro...
> > chromecast/browser/android/cast_window_android.cc:47:
> > window_android->web_contents_->GetRenderWidgetHostView();
> > On 2015/02/24 05:55:09, gunsch wrote:
> > > optional: instead of accessing web_contents_ (private member from a static
> > > method), you could call web_contents() API (provided by
> WebContentsDelegate*).
> > 
> > I don't believe there is such an API?  WebContentsDelegate actually
maintains
> an
> > entire set of WebContents*'s.
> > 
> > Is private member from a static method a problem in the style guide?  If so,
> we
> > could add an accessor into CastWindowAndroid.  If not ... I don't personally
> > have a problem with it, at least not for simple cases like this.
> 
> Ha, sent you down the wrong path because I said WebContentsDelegate when I
meant
> WebContentsObserver :(
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/bro...
> 
> but alternately it's really fine as-is, hence "optional", just a stylistic
> preference and thought I'd point out the API was there. Feel free to submit.

Ok, see it now :)

[halliwell, 2015-02-24 06:32:17]

The CQ bit was checked by halliwell@chromium.org

[commit-bot: I haz the power, 2015-02-24 06:33:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/934433003/20001

[commit-bot: I haz the power, 2015-02-24 06:51:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-24 06:52:10]

Patchset 2 (id:??) landed as
https://crrev.com/f428c79fe88b2458ea659c889227a40383e65e23
Cr-Commit-Position: refs/heads/master@{#317759}