Encode JSON key IDs and keys as base64url

media/cdm/json_web_key_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cdm/json_web_key.h"
 
+#include "base/base64.h"
 #include "base/logging.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace media {
 
 class JSONWebKeyTest : public testing::Test {
  public:
   JSONWebKeyTest() {}
 
  protected:
@@ skipping 101 matching lines @@
       "    {"
       "      \"kty\": \"oct\","
       "      \"alg\": \"A128KW\","
       "      \"kid\": \"AAECAwQFBgcICQoLDA0ODxAREhM\","
       "      \"k\": \"FBUWFxgZGhscHR4fICEiIw\""
       "    },"
       "    {"
       "      \"kty\": \"oct\","
       "      \"alg\": \"A128KW\","
       "      \"kid\": \"JCUmJygpKissLS4vMA\","
-      "      \"k\":\"MTIzNDU2Nzg5Ojs8PT4/QA\""
+      "      \"k\":\"MTIzNDU2Nzg5Ojs8PT4_QA\""
       "    }"
       "  ]"
       "}";
   ExtractJWKKeysAndExpect(kJwksMultipleEntries, true, 2);
 
   // Try a key with no spaces and some \n plus additional fields.
   const std::string kJwksNoSpaces =
       "\n\n{\"something\":1,\"keys\":[{\n\n\"kty\":\"oct\",\"alg\":\"A128KW\","
       "\"kid\":\"AAECAwQFBgcICQoLDA0ODxAREhM\",\"k\":\"GawgguFyGrWKav7AX4VKUg"
       "\",\"foo\":\"bar\"}]}\n\n";
   ExtractJWKKeysAndExpect(kJwksNoSpaces, true, 1);
 
   // Try a list with multiple keys with the same kid.
   const std::string kJwksDuplicateKids =
       "{"
       "  \"keys\": ["
       "    {"
       "      \"kty\": \"oct\","
       "      \"alg\": \"A128KW\","
       "      \"kid\": \"JCUmJygpKissLS4vMA\","
       "      \"k\": \"FBUWFxgZGhscHR4fICEiIw\""
       "    },"
       "    {"
       "      \"kty\": \"oct\","
       "      \"alg\": \"A128KW\","
       "      \"kid\": \"JCUmJygpKissLS4vMA\","
-      "      \"k\":\"MTIzNDU2Nzg5Ojs8PT4/QA\""
+      "      \"k\":\"MTIzNDU2Nzg5Ojs8PT4_QA\""
       "    }"
       "  ]"
       "}";
   ExtractJWKKeysAndExpect(kJwksDuplicateKids, true, 2);
 }
 
 TEST_F(JSONWebKeyTest, ExtractInvalidJWKKeys) {
   // Try a simple JWK key (i.e. not in a set)
   const std::string kJwkSimple =
       "{"
@@ skipping 298 matching lines @@
   // Correct tag, but empty list.
   ExtractKeyFromLicenseAndExpect("{\"kids\":[]}", false, NULL, 0);
 
   // Correct tag, but list doesn't contain a string.
   ExtractKeyFromLicenseAndExpect("{\"kids\":[[\"AQI\"]]}", false, NULL, 0);
 
   // Correct tag, but invalid base64 encoding.
   ExtractKeyFromLicenseAndExpect("{\"kids\":[\"!@#$%^&*()\"]}", false, NULL, 0);
 }
 
+TEST_F(JSONWebKeyTest, Base64UrlEncoding) {

[ddorwin, 2015/02/19 04:45:56]

Ideally, we'd have both special characters. We can do that later once I get some
examples for the spec.

[jrummell, 2015/02/19 18:20:07]

Found one.

+  const uint8 data1[] = { 0x7E, 0x57, 0x1D, 0x03, 0x7E, 0x57, 0x1D, 0x03,
+                          0x7E, 0x57, 0x1D, 0x03, 0x7E, 0x57, 0x1D, 0x03 };
+
+  // Verify that |data1| contains invalid base64url characters when converted
+  // to base64.
+  std::string encoded_text;
+  base::Base64Encode(
+      std::string(reinterpret_cast<const char*>(&data1[0]), arraysize(data1)),
+      &encoded_text);
+  EXPECT_NE(encoded_text.find('+'), std::string::npos);

[ddorwin, 2015/02/19 04:45:56]

Does the encode give us padding? If so, we can check that too (to confirm we do
stripping too).

[jrummell, 2015/02/19 18:20:07]

Added extra case.

+  EXPECT_EQ(encoded_text.find('-'), std::string::npos);
+
+  CreateLicenseAndExpect(
+      data1, arraysize(data1), MediaKeys::TEMPORARY_SESSION,
+      "{\"kids\":[\"flcdA35XHQN-Vx0DflcdAw\"],\"type\":\"temporary\"}");
+
+  ExtractKeyFromLicenseAndExpect(
+      "{\"kids\":[\"flcdA35XHQN-Vx0DflcdAw\"],\"type\":\"temporary\"}", true,
+      data1, arraysize(data1));
+}
+
 }  // namespace media