Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: sky/tools/tester/test_runner.h

Issue 934403002: Remove last uses of InterfaceImpl<> in Sky C++ code (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tools/tester/test_harness_impl.cc ('k') | sky/tools/tester/test_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/tester/test_runner.h
diff --git a/sky/tools/tester/test_runner.h b/sky/tools/tester/test_runner.h
index 5a775355f6a639999d7a85e4b4a98a4e0bd61d57..57bfab2cac22c0ab19da35ea4e03ae81609b0ae1 100644
--- a/sky/tools/tester/test_runner.h
+++ b/sky/tools/tester/test_runner.h
@@ -25,14 +25,13 @@ class TestRunnerClient {
virtual ~TestRunnerClient();
};
-class TestRunner {
+class TestRunner : public mojo::InterfaceFactory<TestHarness> {
public:
TestRunner(TestRunnerClient* client, mojo::View* container,
const std::string& url, bool enable_pixel_dumping);
- virtual ~TestRunner();
+ ~TestRunner() override;
TestRunnerClient* client() const { return client_; }
- TestHarnessFactory* test_harness_factory() { return &test_harness_factory_; }
base::WeakPtr<TestRunner> GetWeakPtr();
void OnTestStart();
@@ -40,7 +39,10 @@ class TestRunner {
const mojo::Array<uint8_t>& pixels);
private:
- TestHarnessFactory test_harness_factory_;
+ // mojo::InterfaceFactory<TestHarness> implementation:
+ void Create(mojo::ApplicationConnection* app,
+ mojo::InterfaceRequest<TestHarness> request) override;
+
mojo::ServiceProviderImpl test_harness_provider_impl_;
TestRunnerClient* client_;
base::WeakPtrFactory<TestRunner> weak_ptr_factory_;
« no previous file with comments | « sky/tools/tester/test_harness_impl.cc ('k') | sky/tools/tester/test_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698