Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: sky/tools/tester/test_runner.cc

Issue 934403002: Remove last uses of InterfaceImpl<> in Sky C++ code (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tools/tester/test_runner.h ('k') | sky/tools/tester/tester.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/tester/test_runner.cc
diff --git a/sky/tools/tester/test_runner.cc b/sky/tools/tester/test_runner.cc
index e187cfa8e44d09a73a3927472ea13ee847910db0..c726989ce10d6e4f0643f8781d8a222359b1bbe5 100644
--- a/sky/tools/tester/test_runner.cc
+++ b/sky/tools/tester/test_runner.cc
@@ -15,16 +15,17 @@ namespace tester {
TestRunnerClient::~TestRunnerClient() {
}
-TestRunner::TestRunner(TestRunnerClient* client, mojo::View* container,
- const std::string& url, bool enable_pixel_dumping)
- : test_harness_factory_(this),
- client_(client),
+TestRunner::TestRunner(TestRunnerClient* client,
+ mojo::View* container,
+ const std::string& url,
+ bool enable_pixel_dumping)
+ : client_(client),
weak_ptr_factory_(this),
enable_pixel_dumping_(enable_pixel_dumping) {
CHECK(client);
mojo::ServiceProviderPtr test_harness_provider;
- test_harness_provider_impl_.AddService(&test_harness_factory_);
+ test_harness_provider_impl_.AddService(this);
test_harness_provider_impl_.Bind(GetProxy(&test_harness_provider));
container->Embed(url, nullptr, test_harness_provider.Pass());
@@ -67,5 +68,10 @@ void TestRunner::OnTestComplete(const std::string& test_result,
client_->OnTestComplete();
}
+void TestRunner::Create(mojo::ApplicationConnection* app,
+ mojo::InterfaceRequest<TestHarness> request) {
+ new TestHarnessImpl(this, request.Pass());
+}
+
} // namespace tester
} // namespace sky
« no previous file with comments | « sky/tools/tester/test_runner.h ('k') | sky/tools/tester/tester.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698