Issue 934403002: Remove last uses of InterfaceImpl<> in Sky C++ code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 934403002: Remove last uses of InterfaceImpl<> in Sky C++ code (Closed)

Created:
5 years, 10 months ago by jamesr

Modified:
5 years, 10 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove last uses of InterfaceImpl<> in Sky C++ code This switches to using StrongBinding<>s in sky's ContentHandlerImpl and TestHarnessImpl implementations. These are the last uses of the deprecated InterfaceImpl<> helper in the mojo repo (more uses exist in other repos). R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d3495a129dcbe679e2d5ac729c85a58acf38f8c4

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -21 lines)			Patch
M	sky/tools/tester/test_harness_impl.h	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	sky/tools/tester/test_harness_impl.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	sky/tools/tester/test_runner.h	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	sky/tools/tester/test_runner.cc	View	2 chunks	+11 lines, -5 lines	0 comments	Download
M	sky/tools/tester/tester.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/viewer/content_handler_impl.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	sky/viewer/content_handler_impl.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	sky/viewer/viewer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

jamesr

5 years, 10 months ago (2015-02-19 02:17:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d3495a129dcbe679e2d5ac729c85a58acf38f8c4 (presubmit successful).