net/tools/quic/quic_client_bin.cc - Issue 934383002: Follow-up to https://codereview.chromium.org/938853002

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_client_bin.cc

Issue 934383002: Follow-up to https://codereview.chromium.org/938853002 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/quic_client_bin.cc

diff --git a/net/tools/quic/quic_client_bin.cc b/net/tools/quic/quic_client_bin.cc

index 66517ca9c197e33cfc3e201778eb41ab1210430f..259111f8782dd6e2e94c74c3c35d5238c24fe0cb 100644

--- a/net/tools/quic/quic_client_bin.cc

+++ b/net/tools/quic/quic_client_bin.cc

@@ -125,10 +125,7 @@ int main(int argc, char *argv[]) {

FLAGS_host = line->GetSwitchValueASCII("host");

}

if (line->HasSwitch("port")) {

- int port;

- if (base::StringToInt(line->GetSwitchValueASCII("port"), &port)) {

- FLAGS_port = port;

- } else {

+ if (!base::StringToInt(line->GetSwitchValueASCII("port"), &FLAGS_port)) {

std::cerr << "--port must be an integer\n";

return 1;

}

« no previous file with comments | « net/quic/quic_server_bin.cc ('k') | no next file » | no next file with comments »