content/common/clipboard_messages.h - Issue 934373002: Marshal the URL parameter of the clipboard bookmark format as a string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/clipboard_messages.h

Issue 934373002: Marshal the URL parameter of the clipboard bookmark format as a string. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add TODO Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/clipboard_messages.h

diff --git a/content/common/clipboard_messages.h b/content/common/clipboard_messages.h

index 5874de6aa2562a8143ecc4f74314ce6eb2078f7e..8e417c071f6f7be55d5e1d61b196ee1c396c1fa1 100644

--- a/content/common/clipboard_messages.h

+++ b/content/common/clipboard_messages.h

@@ -83,9 +83,13 @@ IPC_MESSAGE_CONTROL1(ClipboardHostMsg_WriteSmartPasteMarker,

IPC_MESSAGE_CONTROL2(ClipboardHostMsg_WriteCustomData,

ui::ClipboardType /* type */,

CustomDataMap /* custom data */)

+// TODO(dcheng): The |url| parameter should really be a GURL, but <canvas>'s

+// copy as image tries to set very long data: URLs on the clipboard. Using

+// GURL causes the browser to kill the renderer for sending a bad IPC (GURLs

+// bigger than 2 megabytes are considered to be bad). https://crbug.com/459822

IPC_MESSAGE_CONTROL3(ClipboardHostMsg_WriteBookmark,

ui::ClipboardType /* type */,

- GURL /* url */,

+ std::string /* url */,

base::string16 /* title */)

IPC_SYNC_MESSAGE_CONTROL3_0(ClipboardHostMsg_WriteImage,

ui::ClipboardType /* type */,

« no previous file with comments | « content/browser/renderer_host/clipboard_message_filter.cc ('k') | content/renderer/renderer_clipboard_delegate.cc » ('j') | no next file with comments »