Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Unified Diff: pkg/analyzer/lib/src/generated/element.dart

Issue 93433007: Implement hashCode for classes with equals(). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/element.dart
diff --git a/pkg/analyzer/lib/src/generated/element.dart b/pkg/analyzer/lib/src/generated/element.dart
index 6398dd2a0cd274ce2833b1f14f4741d3ad55d61b..b81700b69a8da0f162222a1b1c6f8faab235c89c 100644
--- a/pkg/analyzer/lib/src/generated/element.dart
+++ b/pkg/analyzer/lib/src/generated/element.dart
@@ -5084,6 +5084,8 @@ class PropertyAccessorElementImpl extends ExecutableElementImpl implements Prope
return super.name;
}
+ int get hashCode => ObjectUtilities.combineHashCodes(super.hashCode, isGetter ? 1 : 2);
+
bool get isAbstract => hasModifier(Modifier.ABSTRACT);
bool get isGetter => hasModifier(Modifier.GETTER);
@@ -6091,6 +6093,8 @@ class BottomTypeImpl extends TypeImpl {
bool operator ==(Object object) => identical(object, this);
+ int get hashCode => 0;
+
bool get isBottom => true;
bool isSupertypeOf(Type2 type) => false;
@@ -6127,7 +6131,9 @@ class DynamicTypeImpl extends TypeImpl {
(element as DynamicElementImpl).type = this;
}
- bool operator ==(Object object) => object is DynamicTypeImpl;
+ bool operator ==(Object object) => identical(object, this);
+
+ int get hashCode => 0;
bool get isDynamic => true;
@@ -7609,6 +7615,8 @@ class VoidTypeImpl extends TypeImpl implements VoidType {
bool operator ==(Object object) => identical(object, this);
+ int get hashCode => 0;
+
bool get isVoid => true;
VoidTypeImpl substitute2(List<Type2> argumentTypes, List<Type2> parameterTypes) => this;

Powered by Google App Engine
This is Rietveld 408576698