Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1609)

Unified Diff: sync/engine/committer_list.cc

Issue 93433006: sync: Introduce ModelTypeRegistry and helpers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More review fixes Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/engine/committer_list.cc
diff --git a/sync/engine/committer_list.cc b/sync/engine/committer_list.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e34d0c56efda33d5eb2781f35bf56b2cca3533ff
--- /dev/null
+++ b/sync/engine/committer_list.cc
@@ -0,0 +1,60 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "sync/engine/committer_list.h"
+
+#include <map>
+
+#include "sync/engine/sync_directory_commit_contribution.h"
+#include "sync/engine/sync_directory_commit_contributor.h"
+#include "sync/protocol/sync.pb.h"
+
+namespace syncer {
+
+typedef std::map<ModelType, size_t> TypeToIndexMap;
+
+CommitterList::CommitterList()
+ : commit_contributor_deleter_(&commit_contributor_map_) {}
+
+CommitterList::~CommitterList() {}
+
+void CommitterList::RegisterType(
+ ModelType type,
+ SyncDirectoryCommitContributor* contributor) {
+ bool inserted =
+ commit_contributor_map_.insert(std::make_pair(type, contributor)).second;
+ DCHECK(inserted) << "Attempt to override existing type handler in map";
+}
+
+void CommitterList::GatherCommitContributions(
+ ModelTypeSet commit_types,
+ size_t max_entries,
+ ContributionMap* contributions) {
+ size_t num_entries = 0;
+ for (ModelTypeSet::Iterator it = commit_types.First();
+ it.Good(); it.Inc()) {
+ CommitContributorMap::iterator cm_it =
+ commit_contributor_map_.find(it.Get());
+ if (cm_it == commit_contributor_map_.end()) {
+ NOTREACHED()
+ << "Could not find requested type " << ModelTypeToString(it.Get())
+ << " in contributor map.";
+ continue;
+ }
+ size_t spaces_remaining = max_entries - num_entries;
+ SyncDirectoryCommitContribution* contribution =
+ cm_it->second->GetContribution(spaces_remaining);
+ if (contribution) {
+ num_entries += contribution->GetNumEntries();
+ contributions->insert(std::make_pair(it.Get(), contribution));
+ }
+ if (num_entries >= max_entries) {
+ DCHECK_EQ(num_entries, max_entries)
+ << "Number of commit entries exceeeds maximum";
+ break;
+ }
+ }
+}
+
+} // namespace syncer

Powered by Google App Engine
This is Rietveld 408576698