Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1415)

Unified Diff: sync/engine/process_updates_util.h

Issue 93433006: sync: Introduce ModelTypeRegistry and helpers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + address comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/engine/process_updates_util.h
diff --git a/sync/engine/process_updates_util.h b/sync/engine/process_updates_util.h
index 6e8bc71b859670ce3012a046584b73a6448abf51..428ff570e20a72569193e1a3ec25a6eb57c3f22d 100644
--- a/sync/engine/process_updates_util.h
+++ b/sync/engine/process_updates_util.h
@@ -5,16 +5,11 @@
#ifndef SYNC_ENGINE_PROCESS_UPDATES_UTIL_H_
#define SYNC_ENGINE_PROCESS_UPDATES_UTIL_H_
-#include <map>
#include <vector>
-#include "base/compiler_specific.h"
-#include "sync/base/sync_export.h"
-#include "sync/engine/syncer_types.h"
#include "sync/internal_api/public/base/model_type.h"
namespace sync_pb {
-class GetUpdatesResponse;
class SyncEntity;
}
@@ -29,20 +24,7 @@ class ModelNeutralWriteTransaction;
class Directory;
}
-class Cryptographer;
-
-// TODO(rlarocque): Move these definitions somewhere else?
typedef std::vector<const sync_pb::SyncEntity*> SyncEntityList;
-typedef std::map<ModelType, SyncEntityList> TypeSyncEntityMap;
-
-// Given a GetUpdates response, iterates over all the returned items and
-// divides them according to their type. Outputs a map from model types to
-// received SyncEntities. The output map will have entries (possibly empty)
-// for all types in |requested_types|.
-void PartitionUpdatesByType(
- const sync_pb::GetUpdatesResponse& updates,
- ModelTypeSet requested_types,
- TypeSyncEntityMap* updates_by_type);
// Processes all the updates associated with a single ModelType.
void ProcessDownloadedUpdates(
@@ -52,22 +34,6 @@ void ProcessDownloadedUpdates(
const SyncEntityList& applicable_updates,
sessions::StatusController* status);
-// Checks whether or not an update is fit for processing.
-//
-// The answer may be "no" if the update appears invalid, or it's not releveant
-// (ie. a delete for an item we've never heard of), or other reasons.
-VerifyResult VerifyUpdate(
- syncable::ModelNeutralWriteTransaction* trans,
- const sync_pb::SyncEntity& entry,
- ModelType requested_type);
-
-// If the update passes a series of checks, this function will copy
-// the SyncEntity's data into the SERVER side of the syncable::Directory.
-void ProcessUpdate(
- const sync_pb::SyncEntity& proto_update,
- const Cryptographer* cryptographer,
- syncable::ModelNeutralWriteTransaction* const trans);
-
} // namespace syncer
#endif // SYNC_ENGINE_PROCESS_UPDATES_UTIL_H_

Powered by Google App Engine
This is Rietveld 408576698