Issue 93433003: Show handles when marking text with touch in NativeTextfieldViews

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 93433003: Show handles when marking text with touch in NativeTextfieldViews (Closed)

Created:
7 years ago by mohsen

Modified:
7 years ago

Reviewers:
sky

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Show handles when marking text with touch in NativeTextfieldViews In NativeTextfieldViews, part of text can be selected using touch scrubbing. After touch scrubbing is finished, touch editing handles should appear to allow more touch selection manipulation. BUG=239111 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238444

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -11 lines)			Patch
	M	ui/views/controls/textfield/native_textfield_views.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	ui/views/controls/textfield/native_textfield_views_unittest.cc	View		5 chunks	+53 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/93433003/1

7 years ago (2013-12-03 17:19:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/93433003/1

7 years ago (2013-12-03 19:16:32 UTC) #4

Message was sent while issue was closed.

Change committed as 238444

Expand Messages | Collapse Messages