test/message/testcfg.py - Issue 934323004: Teach ModuleDescriptor about basic local exports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/message/testcfg.py

Issue 934323004: Teach ModuleDescriptor about basic local exports (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Handled review comments, added message tests Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/message/testcfg.py

diff --git a/test/message/testcfg.py b/test/message/testcfg.py

index 5d6ab8466396847aeb9040cd99e9095302d92761..cfe22f15d70adafc49daefcb68eaa962852132e7 100644

--- a/test/message/testcfg.py

+++ b/test/message/testcfg.py

@@ -36,6 +36,7 @@ from testrunner.objects import testcase

FLAGS_PATTERN = re.compile(r"//\s+Flags:(.*)")

INVALID_FLAGS = ["--enable-slow-asserts"]

+MODULE_PATTERN = re.compile(r"^// MODULE$", flags=re.MULTILINE)

class MessageTestSuite(testsuite.TestSuite):

@@ -63,6 +64,8 @@ class MessageTestSuite(testsuite.TestSuite):

for match in flags_match:

result += match.strip().split()

result += context.mode_flags

+ if MODULE_PATTERN.search(source):

+ result.append("--module")

result = [x for x in result if x not in INVALID_FLAGS]

result.append(os.path.join(self.root, testcase.path + ".js"))

return testcase.flags + result