src/scopeinfo.cc - Issue 934323004: Teach ModuleDescriptor about basic local exports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/scopeinfo.cc

Issue 934323004: Teach ModuleDescriptor about basic local exports (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Handled review comments, added message tests Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/scopeinfo.cc

diff --git a/src/scopeinfo.cc b/src/scopeinfo.cc

index 74aefdb95489e25609136dc2687a071ebecd3c12..10a493f5d6a13add7be2c55669aaf18b7d93bc70 100644

--- a/src/scopeinfo.cc

+++ b/src/scopeinfo.cc

@@ -560,8 +560,8 @@ Handle<ModuleInfo> ModuleInfo::Create(Isolate* isolate,

int i = 0;

for (ModuleDescriptor::Iterator it = descriptor->iterator(); !it.done();

it.Advance(), ++i) {

- Variable* var = scope->LookupLocal(it.name());

- info->set_name(i, *(it.name()->string()));

+ Variable* var = scope->LookupLocal(it.local_name());

+ info->set_name(i, *(it.export_name()->string()));

info->set_mode(i, var->mode());

DCHECK(var->index() >= 0);

info->set_index(i, var->index());