Remove dependency of 'browser_ui' on 'libusb' when building for iOS

Remove dependency of 'browser_ui' on 'libusb' when building for iOS

Change the dependency of 'browser_ui' on 'libusb' to only be present
when OS is neither "ios" nor "android", instead of always having it
and removing it when OS is "android".

BUG=458398
Committed: https://crrev.com/57670dc60f4c50b4fdf84b98701192c9b7389b8c
Cr-Commit-Position: refs/heads/master@{#316890}

[sdefresne, 2015-02-18 18:24:15]

sdefresne@chromium.org changed reviewers:
+ thakis@chromium.org

[sdefresne, 2015-02-18 18:24:15]

Please take a look.

[Nico, 2015-02-18 19:08:12]

lgtm

[Nico, 2015-02-18 19:08:50]

(do you want to do anything in gn land too? or is gn for ios so busted that
that's not worth it yet?)

[sdefresne, 2015-02-18 19:33:44]

New patchsets have been uploaded after l-g-t-m from thakis@chromium.org

[sdefresne, 2015-02-18 19:34:05]

On 2015/02/18 at 19:08:50, thakis wrote:
> (do you want to do anything in gn land too? or is gn for ios so busted that
that's not worth it yet?)

Good point. Fixed (though untested since iOS code does not currently build with
gn).

[sdefresne, 2015-02-18 19:38:43]

On 2015/02/18 at 19:34:05, sdefresne wrote:
> On 2015/02/18 at 19:08:50, thakis wrote:
> > (do you want to do anything in gn land too? or is gn for ios so busted that
that's not worth it yet?)
> 
> Good point. Fixed (though untested since iOS code does not currently build
with gn).

Please take another look at chrome/browser/ui/BUILD.gn.

[Nico, 2015-02-18 19:40:55]

https://codereview.chromium.org/934323003/diff/20001/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/934323003/diff/20001/chrome/browser/ui/BUILD....
chrome/browser/ui/BUILD.gn:410: if (enable_autofill_dialog) {
This is in an if (enable_autofill_dialog) block – is this right?

[sdefresne, 2015-02-18 19:46:43]

https://codereview.chromium.org/934323003/diff/20001/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/934323003/diff/20001/chrome/browser/ui/BUILD....
chrome/browser/ui/BUILD.gn:410: if (enable_autofill_dialog) {
On 2015/02/18 at 19:40:55, Nico wrote:
> This is in an if (enable_autofill_dialog) block – is this right?

Probably not, good catch. Fixed, please take another look.

[Nico, 2015-02-18 19:55:25]

lgtm, thanks!

[sdefresne, 2015-02-18 20:12:45]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2015-02-18 20:13:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/934323003/40001

[commit-bot: I haz the power, 2015-02-18 20:53:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-18 20:53:40]

Patchset 3 (id:??) landed as
https://crrev.com/57670dc60f4c50b4fdf84b98701192c9b7389b8c
Cr-Commit-Position: refs/heads/master@{#316890}