extensions/browser/guest_view/extension_options/extension_options_guest.cc - Issue 934303003: Fixed the bug that caused extension options not to fit their overlays properly when zoomed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.cc

Issue 934303003: Fixed the bug that caused extension options not to fit their overlays properly when zoomed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/extensions/extension_options_overlay.js ('k') | extensions/browser/guest_view/guest_view_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/extension_options/extension_options_guest.cc

diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.cc b/extensions/browser/guest_view/extension_options/extension_options_guest.cc

index 303ee90289e9b3a0cfab205c2e4e2c109dd83e40..f2db3038c85677a26ccde854d186e0fd3814c8ba 100644

--- a/extensions/browser/guest_view/extension_options/extension_options_guest.cc

+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.cc

@@ -162,8 +162,9 @@ bool ExtensionOptionsGuest::IsPreferredSizeModeEnabled() const {

void ExtensionOptionsGuest::OnPreferredSizeChanged(const gfx::Size& pref_size) {

extension_options_internal::PreferredSizeChangedOptions options;

- options.width = pref_size.width();

- options.height = pref_size.height();

+ // Convert the size from physical pixels to logical pixels.

+ options.width = PhysicalPixelsToLogicalPixels(pref_size.width());

+ options.height = PhysicalPixelsToLogicalPixels(pref_size.height());

DispatchEventToView(new GuestViewBase::Event(

extension_options_internal::OnPreferredSizeChanged::kEventName,

options.ToValue()));