Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.cc

Issue 934303003: Fixed the bug that caused extension options not to fit their overlays properly when zoomed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/extension_options/extension_options_guest.cc
diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.cc b/extensions/browser/guest_view/extension_options/extension_options_guest.cc
index 303ee90289e9b3a0cfab205c2e4e2c109dd83e40..f2db3038c85677a26ccde854d186e0fd3814c8ba 100644
--- a/extensions/browser/guest_view/extension_options/extension_options_guest.cc
+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.cc
@@ -162,8 +162,9 @@ bool ExtensionOptionsGuest::IsPreferredSizeModeEnabled() const {
void ExtensionOptionsGuest::OnPreferredSizeChanged(const gfx::Size& pref_size) {
extension_options_internal::PreferredSizeChangedOptions options;
- options.width = pref_size.width();
- options.height = pref_size.height();
+ // Convert the size from physical pixels to logical pixels.
+ options.width = PhysicalPixelsToLogicalPixels(pref_size.width());
+ options.height = PhysicalPixelsToLogicalPixels(pref_size.height());
DispatchEventToView(new GuestViewBase::Event(
extension_options_internal::OnPreferredSizeChanged::kEventName,
options.ToValue()));

Powered by Google App Engine
This is Rietveld 408576698