Fixed the bug that caused extension options not to fit their overlays properly when zoomed.

extensions/browser/guest_view/guest_view_base.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/guest_view/guest_view_base.h"
 
 #include "base/lazy_instance.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/ui/zoom/page_zoom.h"
 #include "components/ui/zoom/zoom_controller.h"
@@ skipping 492 matching lines @@
   }
 
   // Start tracking the new embedder's zoom level.
   StartTrackingEmbedderZoomLevel();
   element_instance_id_ = element_instance_id;
   is_full_page_plugin_ = is_full_page_plugin;
 
   WillAttachToEmbedder();
 }
 
+int GuestViewBase::LogicalPixelsToPhysicalPixels(double logical_pixels) {
+  DCHECK(logical_pixels >= 0);
+  double zoom_factor = GetEmbedderZoomFactor();
+  return static_cast<int>(logical_pixels * zoom_factor + 0.5);
+}
+
+double GuestViewBase::PhysicalPixelsToLogicalPixels(int physical_pixels) {
+  DCHECK(physical_pixels >= 0);
+  double zoom_factor = GetEmbedderZoomFactor();
+  return static_cast<int>(physical_pixels / zoom_factor + 0.5);

[Fady Samuel, 2015/02/18 18:27:31]

Why are you casting to int here and then returning double? Also please avoid
static_cast<int> and +0.5 and use ceil/floor/round instead as appropriate.
Thanks!

[paulmeyer, 2015/02/19 18:42:58]

Done.

+}
+
 void GuestViewBase::DidStopLoading(content::RenderViewHost* render_view_host) {
   if (IsPreferredSizeModeEnabled()) {
     render_view_host->EnablePreferredSizeMode();
   }
   if (!IsDragAndDropEnabled()) {
     const char script[] = "window.addEventListener('dragstart', function() { "
                           "  window.event.preventDefault(); "
                           "});";
     render_view_host->GetMainFrame()->ExecuteJavaScript(
         base::ASCIIToUTF16(script));
@@ skipping 201 matching lines @@
   auto zoom_controller =
       ui_zoom::ZoomController::FromWebContents(embedder_web_contents());
   if (!zoom_controller)
     return 1.0;
 
   double zoom_factor =
       content::ZoomLevelToZoomFactor(zoom_controller->GetZoomLevel());
   return zoom_factor;
 }
 
-int GuestViewBase::LogicalPixelsToPhysicalPixels(double logical_pixels) {
-  DCHECK(logical_pixels >= 0);
-  double zoom_factor = GetEmbedderZoomFactor();
-  return static_cast<int>(logical_pixels * zoom_factor + 0.5);
-}
-
-double GuestViewBase::PhysicalPixelsToLogicalPixels(int physical_pixels) {
-  DCHECK(physical_pixels >= 0);
-  double zoom_factor = GetEmbedderZoomFactor();
-  return physical_pixels * zoom_factor;
-}
-
 void GuestViewBase::SetUpSizing(const base::DictionaryValue& params) {
   // Read the autosize parameters passed in from the embedder.
   bool auto_size_enabled = false;
   params.GetBoolean(guestview::kAttributeAutoSize, &auto_size_enabled);
 
   int max_height = 0;
   int max_width = 0;
   params.GetInteger(guestview::kAttributeMaxHeight, &max_height);
   params.GetInteger(guestview::kAttributeMaxWidth, &max_width);
 
@@ skipping 55 matching lines @@
 void GuestViewBase::RegisterGuestViewTypes() {
   AppViewGuest::Register();
   ExtensionOptionsGuest::Register();
   ExtensionViewGuest::Register();
   MimeHandlerViewGuest::Register();
   SurfaceWorkerGuest::Register();
   WebViewGuest::Register();
 }
 
 }  // namespace extensions