Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 934303002: Timeline: add labels around status bar controls (Closed)

Created:
5 years, 10 months ago by caseq
Modified:
5 years, 9 months ago
Reviewers:
alph, pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, paulirish
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Timeline: add labels around status bar controls BUG=432736 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190935

Patch Set 1 #

Total comments: 1

Patch Set 2 : use ::shadow instead of /deep/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M Source/devtools/front_end/timeline/TimelinePanel.js View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/timelinePanel.css View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
caseq
Screenshot: https://drive.google.com/file/d/0B_yi9xtujhXSdmcybXQ0TGhkeU0/view?usp=sharing
5 years, 10 months ago (2015-02-18 17:40:17 UTC) #2
pfeldman
https://codereview.chromium.org/934303002/diff/1/Source/devtools/front_end/timeline/timelinePanel.css File Source/devtools/front_end/timeline/timelinePanel.css (right): https://codereview.chromium.org/934303002/diff/1/Source/devtools/front_end/timeline/timelinePanel.css#newcode883 Source/devtools/front_end/timeline/timelinePanel.css:883: .status-bar /deep/ .timeline-status-bar-group-label { /deep/ is pretty much always ...
5 years, 10 months ago (2015-02-19 20:10:55 UTC) #3
caseq
Done, ptal.
5 years, 10 months ago (2015-02-20 09:38:59 UTC) #4
caseq
5 years, 9 months ago (2015-02-26 13:18:50 UTC) #6
pfeldman
lgtm
5 years, 9 months ago (2015-02-26 15:55:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934303002/20001
5 years, 9 months ago (2015-02-26 15:58:01 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 17:11:44 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190935

Powered by Google App Engine
This is Rietveld 408576698