Chromium Code Reviews| Index: src/compiler/verifier.cc |
| diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc |
| index 26fd6933c631acddb27311355b3317079ab05983..9185deee1ad31be6c69b79033601741ccf6c838e 100644 |
| --- a/src/compiler/verifier.cc |
| +++ b/src/compiler/verifier.cc |
| @@ -68,16 +68,16 @@ class Verifier::Visitor { |
| void CheckNotTyped(Node* node) { |
| if (NodeProperties::IsTyped(node)) { |
| std::ostringstream str; |
| - str << "TypeError: node #" << node->opcode() << ":" |
| - << node->op()->mnemonic() << " should never have a type"; |
| + str << "TypeError: node #" << node->id() << ":" << *node->op() |
| + << " should never have a type"; |
| V8_Fatal(__FILE__, __LINE__, str.str().c_str()); |
|
Michael Starzinger
2015/02/18 17:37:33
Please use the "FATAL" macro here instead of inlin
titzer
2015/02/19 09:53:04
Done (here and below).
|
| } |
| } |
| void CheckUpperIs(Node* node, Type* type) { |
| if (typing == TYPED && !bounds(node).upper->Is(type)) { |
| std::ostringstream str; |
| - str << "TypeError: node #" << node->opcode() << ":" |
| - << node->op()->mnemonic() << " upper bound "; |
| + str << "TypeError: node #" << node->id() << ":" << *node->op() |
| + << " upper bound "; |
| bounds(node).upper->PrintTo(str); |
| str << " is not "; |
| type->PrintTo(str); |
| @@ -87,8 +87,8 @@ class Verifier::Visitor { |
| void CheckUpperMaybe(Node* node, Type* type) { |
| if (typing == TYPED && !bounds(node).upper->Maybe(type)) { |
| std::ostringstream str; |
| - str << "TypeError: node #" << node->opcode() << ":" |
| - << node->op()->mnemonic() << " upper bound "; |
| + str << "TypeError: node #" << node->id() << ":" << *node->op() |
| + << " upper bound "; |
| bounds(node).upper->PrintTo(str); |
| str << " must intersect "; |
| type->PrintTo(str); |
| @@ -99,10 +99,9 @@ class Verifier::Visitor { |
| Node* input = ValueInput(node, i); |
| if (typing == TYPED && !bounds(input).upper->Is(type)) { |
| std::ostringstream str; |
| - str << "TypeError: node #" << node->opcode() << ":" |
| - << node->op()->mnemonic() << "(input @" << i << " = " |
| - << input->opcode() << ":" << input->op()->mnemonic() |
| - << ") upper bound "; |
| + str << "TypeError: node #" << node->id() << ":" << *node->op() |
| + << "(input @" << i << " = " << input->opcode() << ":" |
| + << input->op()->mnemonic() << ") upper bound "; |
| bounds(input).upper->PrintTo(str); |
| str << " is not "; |
| type->PrintTo(str); |