[turbofan] Simply context specialization and fix for OSR.

[turbofan] Simplify context specialization and fix for OSR.

AstGraphBuilder puts a constant context in from the beginning.
Also fix bug in merging contexts in environment.

R=mstarzinger@chromium.org
BUG=

Committed: https://crrev.com/d050c331ebd4510e7c8b871c50e33ea2564275fa
Cr-Commit-Position: refs/heads/master@{#26745}

[Michael Starzinger, 2015-02-18 17:37:33]

LGTM if comments are addressed.

https://codereview.chromium.org/934293002/diff/1/src/compiler/ast-graph-build...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/934293002/diff/1/src/compiler/ast-graph-build...
src/compiler/ast-graph-builder.cc:441: if (constant_context) {
nit: Can we move this logic into GetFunctionContext, pass in the boolean and
just call it from here?

https://codereview.chromium.org/934293002/diff/1/src/compiler/control-reducer.cc
File src/compiler/control-reducer.cc (right):

https://codereview.chromium.org/934293002/diff/1/src/compiler/control-reducer...
src/compiler/control-reducer.cc:301: V8_Fatal(__FILE__, __LINE__,
str.str().c_str());
Please use the "FATAL" macro here instead of inlining this.

https://codereview.chromium.org/934293002/diff/1/src/compiler/control-reducer...
src/compiler/control-reducer.cc:307: V8_Fatal(__FILE__, __LINE__,
str.str().c_str());
Please use the "FATAL" macro here instead of inlining this.

https://codereview.chromium.org/934293002/diff/1/src/compiler/verifier.cc
File src/compiler/verifier.cc (right):

https://codereview.chromium.org/934293002/diff/1/src/compiler/verifier.cc#new...
src/compiler/verifier.cc:73: V8_Fatal(__FILE__, __LINE__, str.str().c_str());
Please use the "FATAL" macro here instead of inlining this.

https://codereview.chromium.org/934293002/diff/1/src/compiler/verifier.cc#new...
src/compiler/verifier.cc:84: V8_Fatal(__FILE__, __LINE__, str.str().c_str());
Likewise.

https://codereview.chromium.org/934293002/diff/1/src/compiler/verifier.cc#new...
src/compiler/verifier.cc:95: V8_Fatal(__FILE__, __LINE__, str.str().c_str());
Likewise.

https://codereview.chromium.org/934293002/diff/1/src/compiler/verifier.cc#new...
src/compiler/verifier.cc:108: V8_Fatal(__FILE__, __LINE__, str.str().c_str());
Likewise.

[titzer, 2015-02-19 09:44:49]

New patchsets have been uploaded after l-g-t-m from mstarzinger@chromium.org

[titzer, 2015-02-19 09:53:04]

https://codereview.chromium.org/934293002/diff/1/src/compiler/ast-graph-build...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/934293002/diff/1/src/compiler/ast-graph-build...
src/compiler/ast-graph-builder.cc:441: if (constant_context) {
On 2015/02/18 17:37:32, Michael Starzinger wrote:
> nit: Can we move this logic into GetFunctionContext, pass in the boolean and
> just call it from here?

As discussed in person, I've moved this into CreateFunctionContext and inlined
the function_context_.get() at usage sites.

https://codereview.chromium.org/934293002/diff/1/src/compiler/control-reducer.cc
File src/compiler/control-reducer.cc (right):

https://codereview.chromium.org/934293002/diff/1/src/compiler/control-reducer...
src/compiler/control-reducer.cc:301: V8_Fatal(__FILE__, __LINE__,
str.str().c_str());
On 2015/02/18 17:37:32, Michael Starzinger wrote:
> Please use the "FATAL" macro here instead of inlining this.

Done (here and below).

https://codereview.chromium.org/934293002/diff/1/src/compiler/verifier.cc
File src/compiler/verifier.cc (right):

https://codereview.chromium.org/934293002/diff/1/src/compiler/verifier.cc#new...
src/compiler/verifier.cc:73: V8_Fatal(__FILE__, __LINE__, str.str().c_str());
On 2015/02/18 17:37:33, Michael Starzinger wrote:
> Please use the "FATAL" macro here instead of inlining this.

Done (here and below).

[titzer, 2015-02-19 09:54:32]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2015-02-19 09:55:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/934293002/40001

[titzer, 2015-02-19 09:56:36]

The CQ bit was unchecked by titzer@chromium.org

[titzer, 2015-02-19 10:10:41]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2015-02-19 10:11:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/934293002/60001

[commit-bot: I haz the power, 2015-02-19 10:20:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-19 10:20:22]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[titzer, 2015-02-19 11:15:28]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2015-02-19 11:16:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/934293002/40002

[commit-bot: I haz the power, 2015-02-19 11:36:43]

Committed patchset #6 (id:40002)

[commit-bot: I haz the power, 2015-02-19 11:36:59]

Patchset 6 (id:??) landed as
https://crrev.com/d050c331ebd4510e7c8b871c50e33ea2564275fa
Cr-Commit-Position: refs/heads/master@{#26745}