Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 934263002: Update VideoImageGenerator to match new API. (Closed)

Created:
5 years, 10 months ago by scroggo
Modified:
5 years, 10 months ago
Reviewers:
f(malita), DaleCurtis, reed1
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update VideoImageGenerator to match new API. SkImageGenerator is in the process of adding an enum return value to onGetPixels. For staging, it has been replaced with onGetPixelsEnum. (See https://codereview.chromium.org/919693002/) Implement the new API. A follow up change will rename onGetPixelsEnum to onGetPixels. No need to check for null pixels; onGetPixels is only called by getPixels which has already done the check. R=reed@google.com,fmalita@chromium.org BUG=skia:3257 Committed: https://crrev.com/8d58e2c4771cfee729eac8307a62c2eb6752cfa5 Cr-Commit-Position: refs/heads/master@{#317038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M media/filters/skcanvas_video_renderer.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
scroggo
5 years, 10 months ago (2015-02-18 14:42:42 UTC) #1
reed1
skia-side lgtm
5 years, 10 months ago (2015-02-18 14:53:58 UTC) #2
merkulova
I'm completely unfamiliar with skia code, sorry. Removing myself from reviewers.
5 years, 10 months ago (2015-02-18 15:01:33 UTC) #4
reed1
I presume we need a media/ owner... /blink/src/media> cat OWNERS dalecurtis@chromium.org ddorwin@chromium.org jrummell@chromium.org sandersd@chromium.org scherkus@chromium.org ...
5 years, 10 months ago (2015-02-18 15:03:27 UTC) #5
scroggo
Adding an OWNER. dalecurtis@, do you mind taking a look?
5 years, 10 months ago (2015-02-18 15:04:57 UTC) #7
DaleCurtis
rs lgtm given the skia@ folk are happy.
5 years, 10 months ago (2015-02-19 01:30:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934263002/1
5 years, 10 months ago (2015-02-19 12:53:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 14:02:52 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 14:03:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d58e2c4771cfee729eac8307a62c2eb6752cfa5
Cr-Commit-Position: refs/heads/master@{#317038}

Powered by Google App Engine
This is Rietveld 408576698