Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 934253004: Remoting GYP file change and app details python script (Closed)

Created:
5 years, 10 months ago by joedow
Modified:
5 years, 10 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding a python script which will read in a GYP file, convert it to valid JSON, and then load it as a dictionary object. The script will take a set of parameters which will allow the caller to target a set of remoting apps and output a space delimited string containing the target property they are interested in. This output string will be used by other bash/python scripts in a future CL to make generating remoting apps simpler. BUG= Committed: https://crrev.com/d0a878d8b1c32a3030f2d58d8aea312c8e2e79fe Cr-Commit-Position: refs/heads/master@{#316983}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -0 lines) Patch
M remoting/app_remoting_webapp.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A remoting/scripts/webapp/parse_webapp_details.py View 1 chunk +91 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
joedow
Adding a python script which reads in a GYP file and returns a space delimited ...
5 years, 10 months ago (2015-02-18 22:41:37 UTC) #2
garykac
lgtm https://codereview.chromium.org/934253004/diff/1/remoting/scripts/webapp/parse_webapp_details.py File remoting/scripts/webapp/parse_webapp_details.py (right): https://codereview.chromium.org/934253004/diff/1/remoting/scripts/webapp/parse_webapp_details.py#newcode45 remoting/scripts/webapp/parse_webapp_details.py:45: output_string = '' FYI: Most of this function ...
5 years, 10 months ago (2015-02-19 01:24:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934253004/1
5 years, 10 months ago (2015-02-19 02:37:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 03:15:52 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 03:16:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0a878d8b1c32a3030f2d58d8aea312c8e2e79fe
Cr-Commit-Position: refs/heads/master@{#316983}

Powered by Google App Engine
This is Rietveld 408576698