Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 934243003: Fix for cctest/test-api/SetJitCodeEventHandler (Closed)

Created:
5 years, 10 months ago by Igor Sheludko
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix for cctest/test-api/SetJitCodeEventHandler: generate less objects during execution to avoid unwanted GCs. BUG=v8:3899 LOG=N Committed: https://crrev.com/34b5565eb6e963a2d8ca31200bb5d57aedd0416f Cr-Commit-Position: refs/heads/master@{#26721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M test/cctest/test-api.cc View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
5 years, 10 months ago (2015-02-18 13:43:48 UTC) #2
Michael Starzinger
LGTM. Ah, SetJitCodeEventHandler, my old enemy. We meet again!
5 years, 10 months ago (2015-02-18 13:49:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934243003/1
5 years, 10 months ago (2015-02-18 13:50:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 14:02:57 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 14:03:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34b5565eb6e963a2d8ca31200bb5d57aedd0416f
Cr-Commit-Position: refs/heads/master@{#26721}

Powered by Google App Engine
This is Rietveld 408576698