Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 934193002: Revert of [Oilpan] Set stack limit using estimated sizes (Re-land) (Closed)

Created:
5 years, 10 months ago by yhirano
Modified:
5 years, 10 months ago
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of [Oilpan] Set stack limit using estimated sizes (Re-land) (patchset #3 id:40001 of https://codereview.chromium.org/927213002/) Reason for revert: Broke a heap test on Android Nexus4 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20(Nexus4) https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/27126 Original issue's description: > Set the stack limit size based on estimated sizes. > > To check if the stack memory has enough room for recursive > calls, we tried to allocate a large object and assumed the size. > This CL estimate the real thread stack limit using APIs. > On some platforms where such APIs do not work correctly, > we set the limit using the old algorithm. > > --- > This CL is re-land of https://codereview.chromium.org/910663002/ > with fixing a test. > We needed a longer call chain of trace() to expect > to use an alternative marking method, because we got wider > stack memory area to go eagerly. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190388 TBR=oilpan-reviews@chromium.org,kouhei@chromium.org,peria@google.com,haraken@chromium.org,peria@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190403

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -46 lines) Patch
M Source/platform/heap/HeapTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/StackFrameDepth.cpp View 3 chunks +6 lines, -42 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yhirano
Created Revert of [Oilpan] Set stack limit using estimated sizes (Re-land)
5 years, 10 months ago (2015-02-18 08:06:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934193002/1
5 years, 10 months ago (2015-02-18 08:07:14 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-18 08:07:19 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 08:07:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190403

Powered by Google App Engine
This is Rietveld 408576698