chrome/browser/android/banners/app_banner_infobar_delegate.cc - Issue 934183002: Make the ShortcutHelper toast instead of send the user home for web app banners

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_infobar_delegate.cc

Issue 934183002: Make the ShortcutHelper toast instead of send the user home for web app banners (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix existing null access, change for comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/ShortcutHelperTest.java ('k') | chrome/browser/android/shortcut_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/banners/app_banner_infobar_delegate.cc

diff --git a/chrome/browser/android/banners/app_banner_infobar_delegate.cc b/chrome/browser/android/banners/app_banner_infobar_delegate.cc

index 18f146f7c8688d8575398cecb799c1b36625fd11..efc9f310282e6803dcedf98173096c2cde15b06c 100644

--- a/chrome/browser/android/banners/app_banner_infobar_delegate.cc

+++ b/chrome/browser/android/banners/app_banner_infobar_delegate.cc

@@ -157,7 +157,8 @@ bool AppBannerInfoBarDelegate::Accept() {

FROM_HERE,

base::Bind(&ShortcutHelper::AddShortcutInBackgroundWithSkBitmap,

info,

- *app_icon_.get()),

+ *app_icon_.get(),

+ false),

true);

return true;

}