Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 934173002: Revert of Autofill: Use the title attribute as a last resort for finding labels (Closed)

Created:
5 years, 10 months ago by Lei Zhang
Modified:
5 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Autofill: Use the title attribute as a last resort for finding labels (patchset #1 id:1 of https://codereview.chromium.org/921393002/) Reason for revert: Interferes with --show-autofill-type-predictions but doesn't offer enough improvements. Original issue's description: > Autofill: Use the title attribute as a last resort for finding labels. > > Committed: https://crrev.com/036f121626d6a37fcfa41cdd0ba7d82b5cd15db9 > Cr-Commit-Position: refs/heads/master@{#316711} TBR=estade@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/567434ba4fdd0babaa98db1bad7f4540a685c6cd Cr-Commit-Position: refs/heads/master@{#316747}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M chrome/test/data/autofill/heuristics/output/05_checkout_overstock.com.out View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/11_register_macys.com.out View 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Created Revert of Autofill: Use the title attribute as a last resort for finding labels
5 years, 10 months ago (2015-02-18 02:18:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934173002/1
5 years, 10 months ago (2015-02-18 02:19:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 02:20:29 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 02:20:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/567434ba4fdd0babaa98db1bad7f4540a685c6cd
Cr-Commit-Position: refs/heads/master@{#316747}

Powered by Google App Engine
This is Rietveld 408576698