Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6848)

Unified Diff: chrome/browser/history/history_service.h

Issue 934083003: Cleanup HistoryService and HistoryBackend interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@android-backend-provider
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_service.h
diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h
index 6a204c3458b1e77cb930affae507c666d77a8473..2a43211b7facfaecf84b0a58272c53a979e59bfb 100644
--- a/chrome/browser/history/history_service.h
+++ b/chrome/browser/history/history_service.h
@@ -33,10 +33,6 @@
#include "sync/api/syncable_service.h"
#include "ui/base/page_transition_types.h"
-#if defined(OS_ANDROID)
-class AndroidHistoryProviderService;
-#endif
-
class GURL;
class PageUsageRequest;
class SkBitmap;
@@ -81,9 +77,9 @@ class HistoryService : public syncer::SyncableService, public KeyedService {
typedef std::vector<history::PageUsageData*> PageUsageDataList;
// Must call Init after construction. The empty constructor provided only for
- // unit tests. When using the full constructor, |history_client| and |profile|
- // should only be null during testing, while |visit_delegate| may be null if
- // the embedder use another way to track visited links.
+ // unit tests. When using the full constructor, |history_client| may only be
+ // null during testing, while |visit_delegate| may be null if the embedder use
+ // another way to track visited links.
HistoryService();
HistoryService(history::HistoryClient* history_client,
scoped_ptr<history::VisitDelegate> visit_delegate);
@@ -811,10 +807,6 @@ class HistoryService : public syncer::SyncableService, public KeyedService {
// completed.
bool backend_loaded_;
- // Cached values from Init(), used whenever we need to reload the backend.
- base::FilePath history_dir_;
- bool no_db_;
-
// The index used for quick history lookups.
// TODO(mrossetti): Move in_memory_url_index out of history_service.
// See http://crbug.com/138321

Powered by Google App Engine
This is Rietveld 408576698