chrome/browser/history/android/android_provider_backend_unittest.cc - Issue 934083003: Cleanup HistoryService and HistoryBackend interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/android/android_provider_backend_unittest.cc

Issue 934083003: Cleanup HistoryService and HistoryBackend interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@android-backend-provider

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/android/android_provider_backend.h ('k') | chrome/browser/history/history_backend.h » ('j') | chrome/browser/history/history_backend.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/android/android_provider_backend_unittest.cc

diff --git a/chrome/browser/history/android/android_provider_backend_unittest.cc b/chrome/browser/history/android/android_provider_backend_unittest.cc

index 24642457aaf4758352d8e7ae198f182992e3ea72..4703f7708bf583cbed9ea8094c60c543990d6cc5 100644

--- a/chrome/browser/history/android/android_provider_backend_unittest.cc

+++ b/chrome/browser/history/android/android_provider_backend_unittest.cc

@@ -289,8 +289,8 @@ TEST_F(AndroidProviderBackendTest, UpdateTables) {

// HistoryBackend will shutdown after that.

{

scoped_refptr<HistoryBackend> history_backend;

- history_backend = new HistoryBackend(

- temp_dir_.path(), new AndroidProviderBackendDelegate(), history_client_);

+ history_backend =

+ new HistoryBackend(new AndroidProviderBackendDelegate(), history_client_);

history_backend->Init(std::string(), false,

TestHistoryDatabaseParamsForPath(temp_dir_.path()));

history_backend->AddVisits(url1, visits1, history::SOURCE_SYNCED);

@@ -427,8 +427,8 @@ TEST_F(AndroidProviderBackendTest, QueryHistoryAndBookmarks) {

// HistoryBackend will shutdown after that.

{

scoped_refptr<HistoryBackend> history_backend;

- history_backend = new HistoryBackend(

- temp_dir_.path(), new AndroidProviderBackendDelegate(), history_client_);

+ history_backend =

+ new HistoryBackend(new AndroidProviderBackendDelegate(), history_client_);

history_backend->Init(std::string(), false,

TestHistoryDatabaseParamsForPath(temp_dir_.path()));

history_backend->AddVisits(url1, visits1, history::SOURCE_SYNCED);

@@ -1864,8 +1864,8 @@ TEST_F(AndroidProviderBackendTest, QueryWithoutThumbnailDB) {

// HistoryBackend will shutdown after that.

{

scoped_refptr<HistoryBackend> history_backend;

- history_backend = new HistoryBackend(

- temp_dir_.path(), new AndroidProviderBackendDelegate(), history_client_);

+ history_backend =

+ new HistoryBackend(new AndroidProviderBackendDelegate(), history_client_);

history_backend->Init(std::string(), false,

TestHistoryDatabaseParamsForPath(temp_dir_.path()));

history_backend->AddVisits(url1, visits1, history::SOURCE_SYNCED);