Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 934053002: Android notifications should use system default settings for indicators. (Closed)

Created:
5 years, 10 months ago by Peter Beverloo
Modified:
5 years, 10 months ago
Reviewers:
Miguel Garcia
CC:
chromium-reviews, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@n-enable-events
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android notifications should use system default settings for indicators. Per this patch, Web Notifications on Android will inherit the system default settings for the notification sound, vibration and light indicator. These cannot yet be changed by the developer, but can be fully customized by the user in the Android Settings screen. BUG=459268 Committed: https://crrev.com/00f2e79f93b8445179a05dbe03f2306a1dafc25b Cr-Commit-Position: refs/heads/master@{#316663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Miguel Garcia
lgtm
5 years, 10 months ago (2015-02-17 19:56:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934053002/1
5 years, 10 months ago (2015-02-17 20:59:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 21:50:17 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 21:50:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00f2e79f93b8445179a05dbe03f2306a1dafc25b
Cr-Commit-Position: refs/heads/master@{#316663}

Powered by Google App Engine
This is Rietveld 408576698