Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 933993002: NaCl: Update revision in DEPS, badad9a -> 6b9d8cf (Closed)

Created:
5 years, 10 months ago by jvoung (off chromium)
Modified:
5 years, 10 months ago
Reviewers:
Mark Seaborn, JF
CC:
chromium-reviews, JF, native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, badad9a -> 6b9d8cf This pulls in the following Native Client changes: 18dbc93: (jfb@chromium.org) Update revision for PNaCl 6b9d8cf: (jvoung@chromium.org) Workaround for linking nacl_helper_nonsfi w/ newer LLVM gold plugin. 6b9d8cf requires an adjustment to the nacl_helper_nonsfi link_flags (start-group, end-group supplied from the nacl side). BUG=https://code.google.com/p/nativeclient/issues/detail?id=4067 TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build Committed: https://crrev.com/9cae62970bbf2d8ca64b0bd03f5adea033f8ab96 Cr-Commit-Position: refs/heads/master@{#316596}

Patch Set 1 #

Patch Set 2 : with adjustment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl_nonsfi.gyp View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jvoung (off chromium)
5 years, 10 months ago (2015-02-17 16:20:48 UTC) #2
JF
lgtm d=(´▽`)=b lgtm
5 years, 10 months ago (2015-02-17 16:30:14 UTC) #4
Mark Seaborn
LGTM. It would be good to mention in the commit message that 6b9d8cf required the ...
5 years, 10 months ago (2015-02-17 16:30:43 UTC) #5
jvoung (off chromium)
On 2015/02/17 16:30:43, Mark Seaborn wrote: > LGTM. It would be good to mention in ...
5 years, 10 months ago (2015-02-17 16:49:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933993002/20001
5 years, 10 months ago (2015-02-17 16:50:32 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-17 17:29:47 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 17:30:53 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9cae62970bbf2d8ca64b0bd03f5adea033f8ab96
Cr-Commit-Position: refs/heads/master@{#316596}

Powered by Google App Engine
This is Rietveld 408576698