Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: mojo/services/network/net_adapters.cc

Issue 933973002: Return errors from the Mojo network service using an enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/network/net_adapters.cc
diff --git a/mojo/services/network/net_adapters.cc b/mojo/services/network/net_adapters.cc
index 551481d38810370c9968a546fdf5492b2896ab27..24efee312918d67be86ca26dd64874bea7c3d03b 100644
--- a/mojo/services/network/net_adapters.cc
+++ b/mojo/services/network/net_adapters.cc
@@ -109,7 +109,7 @@ MojoToNetIOBuffer::~MojoToNetIOBuffer() {
NetworkErrorPtr MakeNetworkError(int error_code) {
NetworkErrorPtr error = NetworkError::New();
- error->code = error_code;
+ error->code = static_cast<NetworkCode>(error_code);
jamesr 2015/02/18 18:43:06 can you add a set of static_assert<>s that the enu
ppi 2015/02/19 14:22:18 Neat! Done.
if (error_code <= 0)
error->description = net::ErrorToString(error_code);
return error.Pass();

Powered by Google App Engine
This is Rietveld 408576698