Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 933923003: Enable the Push and Notification Service Worker events without a flag. (Closed)

Created:
5 years, 10 months ago by Peter Beverloo
Modified:
5 years, 10 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, zea+watch_chromium.org, tzik, mlamouri+watch-notifications_chromium.org, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, peter+watch_chromium.org, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@n-stable
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable the Push and Notification Service Worker events without a flag. This CL depends on the following one: https://codereview.chromium.org/914373003/ BUG=432527, 350378, 90795 Committed: https://crrev.com/aac285e921542024483af7b5cc8816c3884d9b9f Cr-Commit-Position: refs/heads/master@{#316649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M chrome/browser/notifications/platform_notification_service_browsertest.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/services/gcm/push_messaging_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Peter Beverloo
5 years, 10 months ago (2015-02-17 14:42:22 UTC) #2
Michael van Ouwerkerk
lgtm So many checks...
5 years, 10 months ago (2015-02-17 14:44:52 UTC) #3
nhiroki
lgtm
5 years, 10 months ago (2015-02-17 14:46:44 UTC) #5
Miguel Garcia
lgtm
5 years, 10 months ago (2015-02-17 14:46:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933923003/1
5 years, 10 months ago (2015-02-17 20:04:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 20:53:49 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 20:54:25 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aac285e921542024483af7b5cc8816c3884d9b9f
Cr-Commit-Position: refs/heads/master@{#316649}

Powered by Google App Engine
This is Rietveld 408576698