Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: src/compiler/linkage.cc

Issue 933913002: Fix representation for CompareIC in JSGenericLowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Smash bounds and workaround. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-generic-lowering.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-stubs.h" 5 #include "src/code-stubs.h"
6 #include "src/compiler.h" 6 #include "src/compiler.h"
7 #include "src/compiler/linkage.h" 7 #include "src/compiler/linkage.h"
8 #include "src/compiler/node.h" 8 #include "src/compiler/node.h"
9 #include "src/compiler/pipeline.h" 9 #include "src/compiler/pipeline.h"
10 #include "src/scopes.h" 10 #include "src/scopes.h"
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 // static 97 // static
98 bool Linkage::NeedsFrameState(Runtime::FunctionId function) { 98 bool Linkage::NeedsFrameState(Runtime::FunctionId function) {
99 if (!FLAG_turbo_deoptimization) { 99 if (!FLAG_turbo_deoptimization) {
100 return false; 100 return false;
101 } 101 }
102 102
103 // Most runtime functions need a FrameState. A few chosen ones that we know 103 // Most runtime functions need a FrameState. A few chosen ones that we know
104 // not to call into arbitrary JavaScript, not to throw, and not to deoptimize 104 // not to call into arbitrary JavaScript, not to throw, and not to deoptimize
105 // are blacklisted here and can be called without a FrameState. 105 // are blacklisted here and can be called without a FrameState.
106 switch (function) { 106 switch (function) {
107 case Runtime::kBooleanize:
108 case Runtime::kDeclareGlobals: // TODO(jarin): Is it safe? 107 case Runtime::kDeclareGlobals: // TODO(jarin): Is it safe?
109 case Runtime::kDefineClassMethod: // TODO(jarin): Is it safe? 108 case Runtime::kDefineClassMethod: // TODO(jarin): Is it safe?
110 case Runtime::kDefineGetterPropertyUnchecked: // TODO(jarin): Is it safe? 109 case Runtime::kDefineGetterPropertyUnchecked: // TODO(jarin): Is it safe?
111 case Runtime::kDefineSetterPropertyUnchecked: // TODO(jarin): Is it safe? 110 case Runtime::kDefineSetterPropertyUnchecked: // TODO(jarin): Is it safe?
112 case Runtime::kForInCacheArrayLength: 111 case Runtime::kForInCacheArrayLength:
113 case Runtime::kForInInit: 112 case Runtime::kForInInit:
114 case Runtime::kForInNext: 113 case Runtime::kForInNext:
115 case Runtime::kNewArguments: 114 case Runtime::kNewArguments:
116 case Runtime::kNewClosure: 115 case Runtime::kNewClosure:
117 case Runtime::kNewFunctionContext: 116 case Runtime::kNewFunctionContext:
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 182
184 CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone, 183 CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
185 const MachineSignature* sig) { 184 const MachineSignature* sig) {
186 UNIMPLEMENTED(); 185 UNIMPLEMENTED();
187 return NULL; 186 return NULL;
188 } 187 }
189 #endif // !V8_TURBOFAN_BACKEND 188 #endif // !V8_TURBOFAN_BACKEND
190 } 189 }
191 } 190 }
192 } // namespace v8::internal::compiler 191 } // namespace v8::internal::compiler
OLDNEW
« no previous file with comments | « src/compiler/js-generic-lowering.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698