Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 933913002: Fix representation for CompareIC in JSGenericLowering. (Closed)

Created:
5 years, 10 months ago by Michael Starzinger
Modified:
5 years, 10 months ago
Reviewers:
titzer, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix representation for CompareIC in JSGenericLowering. R=jarin@chromium.org TEST=mjsunit/regress/regress-3884 BUG=v8:3884 LOG=N Committed: https://crrev.com/22dd6dc2a6e1d426491037d5eeddb359d3570fe5 Cr-Commit-Position: refs/heads/master@{#26702}

Patch Set 1 #

Patch Set 2 : Apply Booleanize-b-Gone(TM). #

Patch Set 3 : Smash bounds and workaround. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -65 lines) Patch
M src/compiler/js-generic-lowering.cc View 1 2 2 chunks +48 lines, -9 lines 0 comments Download
M src/compiler/linkage.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 1 chunk +0 lines, -29 lines 0 comments Download
M test/cctest/compiler/test-run-jscalls.cc View 1 1 chunk +0 lines, -20 lines 0 comments Download
M test/cctest/compiler/test-run-jsops.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-3884.js View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Starzinger
5 years, 10 months ago (2015-02-17 15:49:17 UTC) #3
titzer
lgtm
5 years, 10 months ago (2015-02-17 16:13:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933913002/60001
5 years, 10 months ago (2015-02-17 16:17:05 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 10 months ago (2015-02-17 16:37:29 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 16:37:45 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/22dd6dc2a6e1d426491037d5eeddb359d3570fe5
Cr-Commit-Position: refs/heads/master@{#26702}

Powered by Google App Engine
This is Rietveld 408576698