chrome/browser/ui/views/global_error_bubble_view.h - Issue 933893003: Use standard icon/title in global error bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/global_error_bubble_view.h

Issue 933893003: Use standard icon/title in global error bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/global_error_bubble_view.h

diff --git a/chrome/browser/ui/views/global_error_bubble_view.h b/chrome/browser/ui/views/global_error_bubble_view.h

index 33ab6ce2c0ca22f39542f8281d831cfadf971b55..d44786ade88326e9f2a78b3d162a5ce7daab5332 100644

--- a/chrome/browser/ui/views/global_error_bubble_view.h

+++ b/chrome/browser/ui/views/global_error_bubble_view.h

@@ -30,6 +30,9 @@ class GlobalErrorBubbleView : public views::ButtonListener,

// views::WidgetDelegate implementation.

void WindowClosing() override;

msw 2015/02/20 20:03:44 Ping! The order here (and in the code file) should

xiaoling 2015/02/20 20:23:18 Done.

+ base::string16 GetWindowTitle() const override;

+ bool ShouldShowWindowIcon() const override;

+ gfx::ImageSkia GetWindowIcon() override;

// views::BubbleDelegateView implementation.

bool ShouldShowCloseButton() const override;