Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7937)

Unified Diff: chrome/browser/ui/views/global_error_bubble_view.h

Issue 933893003: Use standard icon/title in global error bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/global_error_bubble_view.h
diff --git a/chrome/browser/ui/views/global_error_bubble_view.h b/chrome/browser/ui/views/global_error_bubble_view.h
index 33ab6ce2c0ca22f39542f8281d831cfadf971b55..f85f94fbbce59dc0fbfb738000b16df655fcb165 100644
--- a/chrome/browser/ui/views/global_error_bubble_view.h
+++ b/chrome/browser/ui/views/global_error_bubble_view.h
@@ -30,6 +30,10 @@ class GlobalErrorBubbleView : public views::ButtonListener,
// views::WidgetDelegate implementation.
void WindowClosing() override;
+ bool ShouldShowWindowTitle() const override;
msw 2015/02/19 23:56:14 nit: make the declaration and definition order of
+ base::string16 GetWindowTitle() const override;
+ bool ShouldShowWindowIcon() const override;
+ gfx::ImageSkia GetWindowIcon() override;
// views::BubbleDelegateView implementation.
bool ShouldShowCloseButton() const override;

Powered by Google App Engine
This is Rietveld 408576698