Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 933863002: [strong] make --use-strong flag work in d8 (Closed)

Created:
5 years, 10 months ago by rossberg
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] make --use-strong flag work in d8 This broke with the TSAN fix. R=marja@chromium.org BUG= Committed: https://crrev.com/5c847d1f09dbb29f4fa8340528540d1682731e59 Cr-Commit-Position: refs/heads/master@{#26687}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M src/d8.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.js View 10 chunks +14 lines, -14 lines 0 comments Download
A test/mjsunit/strong/use-strong-flag.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rossberg
5 years, 10 months ago (2015-02-17 11:45:14 UTC) #1
marja
lgtm
5 years, 10 months ago (2015-02-17 11:47:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933863002/1
5 years, 10 months ago (2015-02-17 11:47:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 12:07:55 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5c847d1f09dbb29f4fa8340528540d1682731e59 Cr-Commit-Position: refs/heads/master@{#26687}
5 years, 10 months ago (2015-02-17 12:08:09 UTC) #6
arv (Not doing code reviews)
5 years, 10 months ago (2015-02-17 22:37:39 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698