Issue 933853004: Remove SK_SUPPORT_LEGACY_GET_PIXELS_ENUM.

Issue 933853004: Remove SK_SUPPORT_LEGACY_GET_PIXELS_ENUM. (Closed)

Created:
5 years, 10 months ago by scroggo

Modified:
5 years, 10 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Remove SK_SUPPORT_LEGACY_GET_PIXELS_ENUM. SK_SUPPORT_LEGACY_GET_PIXELS_ENUM just set a \#define to convert onGetPixelsEnum to onGetPixels Now that Chrome has been updated to override onGetPixels, there is no need for the define. BUG=skia:3257 Committed: https://skia.googlesource.com/skia/+/953df445aba3e657ab3a3b0da8041ff0a7e72b5f

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	gyp/skia_for_chromium_defines.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	include/core/SkImageGenerator.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 8 (2 generated)

scroggo

On 2015/02/20 16:46:34, reed1 wrote: > I presume chrome has its fixes for this. > ...

5 years, 10 months ago (2015-02-20 16:51:09 UTC) #4

reed1

On 2015/02/20 16:51:09, scroggo wrote: > On 2015/02/20 16:46:34, reed1 wrote: > > I presume ...

5 years, 10 months ago (2015-02-20 16:51:47 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933853004/1

5 years, 10 months ago (2015-02-23 14:53:29 UTC) #7

commit-bot: I haz the power

5 years, 10 months ago (2015-02-23 15:07:28 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/953df445aba3e657ab3a3b0da8041ff0a7e72b5f