Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3922)

Unified Diff: chrome/browser/interstitials/security_interstitial_metrics_helper.cc

Issue 933853003: Identify localhost/ipaddress in RapporSamples (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/rappor/sampling.cc » ('j') | chrome/browser/metrics/rappor/sampling.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/interstitials/security_interstitial_metrics_helper.cc
diff --git a/chrome/browser/interstitials/security_interstitial_metrics_helper.cc b/chrome/browser/interstitials/security_interstitial_metrics_helper.cc
index 322220e30564173ece0a56dff8ffd54dc6920cb7..2c7961be03ca159819129343b1816ac80ea01a19 100644
--- a/chrome/browser/interstitials/security_interstitial_metrics_helper.cc
+++ b/chrome/browser/interstitials/security_interstitial_metrics_helper.cc
@@ -10,6 +10,7 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/history/history_service.h"
#include "chrome/browser/history/history_service_factory.h"
+#include "chrome/browser/metrics/rappor/sampling.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/webdata/web_data_service_factory.h"
#include "components/rappor/rappor_service.h"
@@ -69,11 +70,9 @@ void SecurityInterstitialMetricsHelper::RecordUserDecision(
rappor::RapporService* rappor_service = g_browser_process->rappor_service();
if (rappor_service && rappor_reporting_ == REPORT_RAPPOR &&
(decision == PROCEED || decision == DONT_PROCEED)) {
- // |domain| will be empty for hosts w/o TLDs (localhost, ip addrs)
- const std::string domain =
- net::registry_controlled_domains::GetDomainAndRegistry(
- request_url_,
- net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES);
+ // |domain| will be empty for hosts w/o TLDs
+ const std::string domain = rappor::GetDomainAndRegistrySampleFromGURL(
+ request_url_);
// e.g. "interstitial.malware.domain" or "interstitial.ssl.domain"
const std::string metric_name =
« no previous file with comments | « no previous file | chrome/browser/metrics/rappor/sampling.cc » ('j') | chrome/browser/metrics/rappor/sampling.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698